I ound the problem, I put Eveready batteries in it that are metal cased. The clips that hold the batteries connect to the terminals so the cases of the batteries were shorting out the battery holder. Put some plastic coated batteries in and it's now all good.
